feat(gdocs): narrative charts component #4295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-12-18 21:58:24 UTC |
marcelgerber
force-pushed
the
narrative-views-gdocs
branch
6 times, most recently
from
a985301 to
62e4ec6
Compare
marcelgerber
force-pushed
the
narrative-views-gdocs
branch
from
62e4ec6 to
10da0a2
Compare
marcelgerber
changed the title
danyx23
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Very nice work! No notes on the code :)
Feature wise I think the two things that would be nice to still do is an admin button to hide all controls and a way to see the name, ideally instead of the slug. I think these two features are high enough value to wait for those before shipping, otherwise this is ready!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, this is now finally ready for review 🎉
This PR gets us pretty much all the way there to launch, sans some nice-to-have features.
Related project: #4128
A few notes:
/admin/chartViews, this is due to an unrelated issue that I'm gonna put a PR up for soonThings still missing
Some things are missing, but afaict all of these are nice-to-haves, really.
See #4128 for a comprehensive list, but a few I'll also list here: